Skip to content

dd4hep: add g4hepem patch#954

Open
wdconinc wants to merge 1 commit into
developfrom
dd4hep-g4hepem
Open

dd4hep: add g4hepem patch#954
wdconinc wants to merge 1 commit into
developfrom
dd4hep-g4hepem

Conversation

@wdconinc

@wdconinc wdconinc commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR backports the G4HepEm plugin to DD4hep 1.36.

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: DD4hep G4HepEm plugin)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI review requested due to automatic review settings June 9, 2026 23:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dd4hep Spack overlay package to support building the G4HepEm plugin for DD4hep 1.36 via an upstream patch and a new build variant.

Changes:

  • Add a +g4hepem variant (default enabled) for DD4hep @1.36: when +ddg4 is enabled.
  • Add a conditional dependency on g4hepem when +g4hepem.
  • Apply a backport patch for DD4hep @1.36:1.37 and wire the variant into CMake via DD4HEP_USE_G4HEPEM.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spack_repo/eic/packages/dd4hep/package.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants