jana2: backport perfetto#946
Draft
wdconinc wants to merge 3 commits into
Draft
Conversation
## 🤖 Automated Style Fixes This PR applies automated style fixes for #946. ### Changes Applied - `spack style --fix` formatting - Ensures compliance with Spack style guidelines ### Original PR - **Number**: #946 - **Branch**: `jana2-perfetto` - **Title**: jana2: backport perfetto ### How to Use 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin style-fix-pr-946 git merge origin/style-fix-pr-946 ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/26767087507).* Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports Perfetto tracing support into the jana2 Spack package for the 2026.02.00 release, exposing it as an optional build-time feature.
Changes:
- Add a new
+perfettovariant for JANA2 (intended for@2026.02.00). - Apply an upstream JANA2 patch that introduces Perfetto tracing support for
@2026.02.00. - Plumb the variant into CMake via
-DUSE_PERFETTO={ON,OFF}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
12 tasks
Contributor
Author
|
Patch does not apply cleanly to v2026.02.00 :-( |
auto-merge was automatically disabled
June 7, 2026 22:11
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR backports the JANA2 perfetto functionality to 2026.02.00. Screenshot in JeffersonLab/JANA2#497.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply