Continued Work From Zaro#5
Open
Swiddow wants to merge 41 commits into
Open
Conversation
I've overhauled the core components and rewritten (almost) everything in coffeescript. API/Service submodules now contain Client classes that provide methods for the simplest possible access to MWS functionality. Due to the core changes, these changes will break any existing code. However, I tried to keep things as close as possible.
Almost done with the newer FBA module, finally. Will get this branch working well enough to replace main branch asap.
Updated just about everything and fixed any errors that were preventing use of this branch. See the test folder for up to date samples.
…tToken presense for detecting nextToken
…t where usually CSV data is returned
…/xml', detect that case and parse it as XML
…D5 and unknown content
…ntain UTF-8 characters
…tMatchingProductForId
…he calls require single marketplaceid
…since invoke() modifies the options parameter
Added in functions for Core, FBA, and Reports javascript. Did not edit the coffee script for them since I don't know coffee script and was only using the .js files.
Bugfixed the feeds.js submit feed request. Added Get My Price for SKU and ASIN to products.
Fix: MWS_ORDERS to MWS_FEEDS
added require util to products api test
added getFeedSubmissionResult to test/feeds.coffee to demonstrate an error regarding content type:
{ Type: {},
Code: 'Client_UknownContent',
Message: 'Unrecognized content format: application/octet-stream' }
Fix for undefined variable "options" in feeds.js / feeds.coffee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is code continuation of the node.js API library forked from zaro's code. I am making use of the .js portions of it, as I do not use coffee script, so that code is not being maintained by me. I have made a few bugfixes and additions to the core, products, and FBA portions of the library, and intend to do more by the end of my usage of it.