feat: add learner intent xpert api endpoint#212
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f6f1ba1 to
c77d518
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (93.87%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 86.52% 86.51% -0.01%
==========================================
Files 154 156 +2
Lines 12920 12970 +50
Branches 1233 1234 +1
==========================================
+ Hits 11179 11221 +42
- Misses 1425 1430 +5
- Partials 316 319 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6b81caf to
96f693e
Compare
96f693e to
5476ef8
Compare
|
|
||
| def test_learning_intent_scope_in_default_throttle_rates(self): | ||
| rates = django_settings.REST_FRAMEWORK.get('DEFAULT_THROTTLE_RATES', {}) | ||
| self.assertIn('learner_pathways_learning_intent', rates) |
There was a problem hiding this comment.
Nit: use modern pytest-style assertions, e.g.:
| self.assertIn('learner_pathways_learning_intent', rates) | |
| assert 'learner_pathways_learning_intent' in rates |
There was a problem hiding this comment.
inform: I have updated the PR, but, there are over 100+ instances of assertIn as a validation approach spanning features like checkout intent, customer billing, provisioning, subsidy access policy, checkout intent/checkout bff and browse and request whereas the modern approach is used sparingly in comparison.
Should there be a seperate initiative via a ticket to modernize the testing prose documented in a separate ticket?
There was a problem hiding this comment.
As a followup, the skills may also need to be updated to avoid legacy/non-modern approaches to test writing
Description:

Adds the first Learner Pathways Xpert-backed API endpoint for deriving structured learning intent from learner input.
What changed
Jira:
ENT-11858
Merge checklist:
./manage.py makemigrationshas been runPost merge: