Ent 11903 bffcheckout price api by tsunkara-sonata · Pull Request #207 · edx/enterprise-access

tsunkara-sonata · 2026-06-22T08:23:49Z

Jira:
https://2u-internal.atlassian.net/browse/ENT-11903

Description:

BFF context endpoint returns pricing with ssp_product_slug in every price object — the BFF context route returns pricing data organized by Stripe lookup_key. After this step, every price object returned by the BFF — including all academies and Teams products — will include the ssp_product_slug field. This gives the frontend a unified, product-centric identifier across the entire pricing response, not just a subset.

Checkout intent creation accepts ssp_product_slug — Currently, the BFF route for creating a checkout intent receives a stripe_price_id directly from the client. After this change, it will accept an ssp_product_slug from the client, look up the corresponding SspProduct record, retrieve the stripe_price_lookup_key

codecov · 2026-06-22T08:27:21Z

Codecov Report

❌ Patch coverage is 97.36842% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.00%. Comparing base (0854543) to head (2b64a21).

Files with missing lines	Patch %	Lines
enterprise_access/apps/customer_billing/api.py	97.61%	0 Missing and 1 partial ⚠️
...rprise_access/apps/customer_billing/pricing_api.py	95.23%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   86.52%   87.00%   +0.48%     
==========================================
  Files         154      154              
  Lines       12920    12975      +55     
  Branches     1233     1244      +11     
==========================================
+ Hits        11179    11289     +110     
+ Misses       1425     1377      -48     
+ Partials      316      309       -7

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rthota-sonata-hue

Looks good for merge. Approved.

iloveagent57 · 2026-06-23T15:07:39Z

        Creates a new CheckoutIntent.
        """
        try:
+            ssp_product_slug = validated_data.pop('ssp_product', None)


since this is a ModelSerializer, validated_data['ssp_product'] should already be resolved to an SspProduct instance by DRF. so one line should be enough, here:

ssp_product = validated_data.pop('ssp_product', None)

iloveagent57 · 2026-06-23T15:08:25Z

+                    'stripe_price_id': 'price_abc123',
+                },
+                format='json',
+            )


Is there a test anywhere that sends an ssp_product key in the request payload?

Updated test passing the payload

iloveagent57 · 2026-06-23T15:23:05Z

+    settings_quantity_ranges = {}
+    for product_config in getattr(settings, 'SSP_PRODUCTS', {}).values():
+        lk = product_config.get('lookup_key')
+        qr = product_config.get('quantity_range')
+        if lk and qr:
+            settings_quantity_ranges[lk] = qr
+    for ssp_product in SspProduct.objects.filter(is_active=True):
+        lookup_key = ssp_product.stripe_price_lookup_key


Ah, ok, this code represents something we're missing from SspProduct: the allowable quantity range as fields (min, max).
Currently, our stage/prod env configs don't include entries for each SspProduct, so all of the products except the base teams one will have no allowable quantity ranges available.
The cleanest path forward right now is to add a new setting like DEFAULT_SSP_QUANTITY_RANGE = [5, 50] (the same as the teams plan) and use that value directly here in this function for price_data['quantity_range']

iloveagent57 · 2026-06-23T15:26:18Z

+    product, _ = SspProduct.objects.get_or_create(
+        slug=settings.SSP_DEFAULT_PRODUCT_SLUG,
+        defaults={
+            'stripe_price_lookup_key': 'teams_subscription_license_yearly',


This line hard-codes something that should be configuration, and also can create records with a totally random catalog query uuid. I would undo this change and remove the related migration.

iloveagent57 · 2026-06-23T15:28:49Z

+        ssp_slug = None
+        try:
+            ssp_slug = product.metadata.get('ssp_product_slug') if getattr(product, 'metadata', None) else None
+        except Exception:  # pylint: disable=broad-exception-caught
+            ssp_slug = None


this is overly defensive, we're already directly accessing product.metadata a few lines above. Replace this whole block with

ssp_slug = product.metadata.get('ssp_product_slug')

If I remove this defensive, I am getting output for price as empty object in /api/v1/bffs/checkout/context/.

iloveagent57 · 2026-06-23T15:29:37Z

+        if ssp_slug:
+            base_data['ssp_product_slug'] = ssp_slug


why not always include the key and let the value be null? that is, why is the if ssp_slug check necessary here?

iloveagent57 · 2026-06-23T15:30:20Z

+                try:
+                    ssp = SspProduct.objects.filter(stripe_price_lookup_key=lookup_key).only('slug').first()
+                    if ssp:
+                        ssp_slug = ssp.slug
+                except Exception:  # pylint: disable=broad-exception-caught
+                    logger.exception('Error looking up SspProduct for lookup_key %s', lookup_key)


you don't need a try/except for this.

iloveagent57 · 2026-06-23T15:32:32Z


    user = input_data['user']
-
+    # ── Resolve slug ↔ price_id BEFORE creating intent ──


nit: unicode arrow

iloveagent57 · 2026-06-23T15:36:14Z

    user = input_data['user']
-
+    # ── Resolve slug ↔ price_id BEFORE creating intent ──
+    ssp_pricing = get_ssp_product_pricing()


we should only do this if the caller hasn't provided an ssp_product_slug. or better yet, let's not do it at all and fetch either the requested SspProduct by slug, or the one specified by SSP_DEFAULT_PRODUCT_SLUG.

tsunkara-sonata requested review from a team as code owners June 22, 2026 08:23

tsunkara-sonata force-pushed the ENT-11903-bffcheckout-priceAPI branch 4 times, most recently from 8a25aee to 1b9226b Compare June 22, 2026 19:31

rthota-sonata-hue approved these changes Jun 23, 2026

View reviewed changes

iloveagent57 requested changes Jun 23, 2026

View reviewed changes

tsunkara-sonata added 4 commits June 25, 2026 09:32

feat: bff checkout update

92f9f51

feat: added addressed comments

40bf720

feat: updated test and quality issues

dd3ea68

feat: code coverage fix

2b34fb8

tsunkara-sonata force-pushed the ENT-11903-bffcheckout-priceAPI branch from 4e8510d to 2b34fb8 Compare June 25, 2026 09:32

tsunkara-sonata added 3 commits June 25, 2026 13:28

feat: updated checkout intent

907200a

feat: cleanup in customer serializer

7145935

Merge branch 'main' into ENT-11903-bffcheckout-priceAPI

2b64a21


		user = input_data['user']

		# ── Resolve slug ↔ price_id BEFORE creating intent ──

Uh oh!

Conversation

tsunkara-sonata commented Jun 22, 2026

Uh oh!

codecov Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rthota-sonata-hue left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jun 22, 2026 •

edited

Loading