Skip to content

fix: fix filter not working on orga page#275

Merged
neferin12 merged 1 commit into
mainfrom
develop
Mar 2, 2026
Merged

fix: fix filter not working on orga page#275
neferin12 merged 1 commit into
mainfrom
develop

Conversation

@neferin12

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the users and tasks filter arrays on the organization activities page were not being sent correctly to the server. By default, Axios v1.x serializes array query parameters with bracket/index notation (e.g., users[0]=id1&users[1]=id2), but the server's tsoa @Query() users?: Array<string> parameter expects repeated-key notation (e.g., users=id1&users=id2). Adding paramsSerializer: { indexes: null } to the Axios request config instructs Axios to use the repeated-key format, making the filter functional.

Changes:

  • Added paramsSerializer: { indexes: null } to the orga/activities GET request so array query params (users, tasks) are serialized in the repeated-key format the server expects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neferin12 neferin12 merged commit af65430 into main Mar 2, 2026
26 checks passed
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version timeclicker_client-v3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version timeclicker_client-v3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants