[codex] Fix E2E workflow crash and PHPUnit alerts#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The failing main run after PR #16 died inside the PHP built-in server during Playwright execution. The workflow change in that PR introduced
PHP_CLI_SERVER_WORKERS=4; the uploadedphp-server.logshowed four CLI server workers starting and then the server dropping out, which left the suite withsocket hang up/ECONNREFUSEDerrors.The two new Dependabot alerts were both on
phpunit/phpunitfromcomposer.lock. One was real and is fixed by moving from9.6.25to9.6.34. The other used the advisory range<= 12.5.21, which incorrectly sweeps in PHPUnit 9.x, so I dismissed alert #88 as inaccurate.Validation
24599705526and downloaded the uploadedphp-server.loggh apicomposer.lockin a PHP 7.4 containercomposer install --dry-run --no-interaction --no-security-blockingFollow-up