Skip to content

Enable propagation of Mirror'ed node state#367

Merged
marcosbento merged 8 commits into
developfrom
task/propagate_mirror_state
Jun 30, 2026
Merged

Enable propagation of Mirror'ed node state#367
marcosbento merged 8 commits into
developfrom
task/propagate_mirror_state

Conversation

@marcosbento

@marcosbento marcosbento commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

This enables the use of option --propagate to trigger the propagation of the state of a Mirror'ed node.

Fixes #353

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-367

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.73494% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.98%. Comparing base (12ed1b6) to head (14991a8).

Files with missing lines Patch % Lines
Viewer/ecflowUI/src/VMirrorAttr.cpp 0.00% 14 Missing ⚠️
libs/node/src/ecflow/node/MirrorAttr.cpp 35.71% 9 Missing ⚠️
...ervice/src/ecflow/service/mirror/MirrorService.cpp 40.00% 3 Missing ⚠️
libs/node/src/ecflow/node/MirrorAttr.hpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #367      +/-   ##
===========================================
+ Coverage    50.92%   50.98%   +0.05%     
===========================================
  Files         1239     1240       +1     
  Lines        99319    99438     +119     
  Branches     14958    14960       +2     
===========================================
+ Hits         50579    50698     +119     
  Misses       48740    48740              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento force-pushed the task/propagate_mirror_state branch 2 times, most recently from 6d40f41 to d540d4d Compare June 26, 2026 12:23
These debug messages happen every second, within the ecflow server
internal loop, and are considered too noisy.

Re ECFLOW-2098
@marcosbento marcosbento force-pushed the task/propagate_mirror_state branch from d540d4d to deaa0ec Compare June 30, 2026 07:47
This enables the Mirror attribute to propagate
the node state propagation up the tree.

Re GH#353
@marcosbento marcosbento force-pushed the task/propagate_mirror_state branch from deaa0ec to e5f6241 Compare June 30, 2026 10:55
@marcosbento marcosbento force-pushed the task/propagate_mirror_state branch from e5f6241 to 14991a8 Compare June 30, 2026 11:01
@marcosbento marcosbento merged commit 33df2d4 into develop Jun 30, 2026
138 checks passed
@marcosbento marcosbento deleted the task/propagate_mirror_state branch June 30, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirror family does not turn complete

2 participants