feat: custom discrete cosine transform#1151
Draft
dietervdb-meteo wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EXPERIMENTAL
The current DCT implementation, which relies on
torch-dct, has an issue which might be quite specific to RMI:These two combine in a destructive way, since 1069 is a large prime number which does not go well with the
HipFFTbackend on Rocm.For this reason we implement a custom made 2d DCT into anemoi. It currently avoids FFT completely and works via explicit matrix multiplication, so that it will also work for grids with relatively large prime number sizes. Note that the default
torch_dct.dct_2ddoes not seem a very optimized implementation, so it could be the custom implementation here improves on it in general.This is currentlty a draft PR, performance and sanity still needs to be checked.
Since we want to test this in our particular setup (CERRA based LAM) this is PR towards #1143 rather than main.
Example use in config:
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.