feat(models): Add wrapper class for InverseReducedSHT#1146
Open
samhatfield wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #1106 added wrapper classes for inverse spherical harmonic transforms on a regular grid and octahedral grid. However no class was added for a "classic" reduced Gaussian grid, such as N320. This PR completes the set by adding
InverseReducedSHT. This came up in discussions with @sahahner.Note that there is no test suite for the wrapper classes,
ReducedSHT,OctahedralSHT,InverseReducedSHTetc. Instead the test suite operates at the "helper class" level (i.e. the underlying grid-agnostic classesSphericalHarmonicTransformandInverseSphericalHarmonicTransformare tested). In future I am planning to refactor the test suite so it targets the wrapper classes, instead. Since the wrapper depends on the helper, both will be tested, rather than just the latter at the moment.In the meantime, I tested this PR through these two tests which I didn't commit:
Test suite
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.