maximum and minimum variables added to MEAN_FIELDS list#365
Open
EddyCMWF wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the daily statistics adaptor so that additional “since previous post-processing” variables (min/max and wind gust) are handled with the same temporal shifting logic as existing mean/accumulated variables, and introduces a config hook to extend that behavior for future variables.
Changes:
- Added several “since previous post-processing” variables (min/max temperature, wind gust, min/max precipitation rate) to
MEAN_FIELDS. - Extended the time-shift condition in
retrieve_list_of_resultsto includeextra_temporally_aggregated_variablesfrom config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+383
to
387
| if var in ACCUMULATED_FIELDS + MEAN_FIELDS + ensure_list( | ||
| # Allow for extra variables to be treated as accumulated, based on config | ||
| self.config.get("extra_temporally_aggregated_variables", []) | ||
| ): | ||
| this_hour = time_zone_hour - accumulation_period |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user identifies that the "minimum/maximum since" variables should be handled like the mean/accumulated variables. This PR adds those variables to the MEAN_FIELDS list, and provides the option to append to the list in case similar things are identified in the future.