Feature/download from eumds for url adaptor#361
Merged
ecmwf-cobarzan merged 5 commits intoMay 28, 2026
Conversation
9eeeddd to
d856482
Compare
…AI generated, adjusted)
d856482 to
d8db1e0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a pluggable “download interface” layer to the URL adaptor so it can download either via the existing multi-URL downloader or via EUMETSAT Data Store (EUMDAC), with EUMDAC downloads post-processed to extract NetCDF files from zip bundles.
Changes:
- Introduces
DownloadInterfaceTypewithMultiUrlDownloadInterfaceandEumdacDownloadInterface, plus aget_download_interface(...)factory. - Refactors
UrlCdsAdaptor.retrieve_list_of_results()to delegate downloading + post-processing to the selected interface (download_interface_type, defaultmultiurl). - Adds unit tests for the interface factory and EUMDAC NetCDF-only zip extraction behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_50_url_adaptor.py |
Adds tests for download interface selection and EUMDAC post-processing of zip bundles. |
cads_adaptors/adaptors/url/download_interface_type.py |
Adds the new download interface abstraction with MultiURL + EUMDAC implementations and a factory. |
cads_adaptors/adaptors/url/__init__.py |
Switches UrlCdsAdaptor to use the new download interface abstraction during retrieval. |
Comments suppressed due to low confidence (1)
cads_adaptors/adaptors/url/init.py:57
retrieve_list_of_resultsnow delegates todownload_interface_type(including auth decryption viaprepare_credentials()andpost_process()behavior), but there’s no test covering that UrlCdsAdaptor selects the correct interface and preserves the previoustry_downloadbehavior for the default case. Add a test that monkeypatchesget_download_interface(orurl_tools.try_download) to assert the correct calls/kwargs for the defaultmultiurlpath and for theeumdacpath.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
EddyCMWF
reviewed
May 27, 2026
EddyCMWF
approved these changes
May 27, 2026
Contributor
Author
|
All cads-e2e-tests passed wrt the URL adaptor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.