Contribution proposal by ETAS#1
Open
ChansAlive wants to merge 6 commits into
Open
Conversation
Co-authors: athul.mallappallil@etas.com, oliver.heilwagen@etas.com, sebastian.lobsinger@etas.com, guruprasad.bhat@etas.com, sunilkumar.prasanchand@etas.com, tibor.zavartkay@etas.com
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
* Update devcontainer. * Add pre-commit config. - disabled copyright check (for now) - format-fix - generate-compile-commands - clang-format - clang-tidy * Add clang-format file * Add clang-tidy file * Update README to avoid common devcontainer pitfalls.
- std::cerr under the folder score replaced with score::mw::log::LogError() - std::cout is replaced with score::mw::log::LogDebug(), those with ERROR in their body are replaced with score::mw::log::LogError() - std::cout/cerr under tests remain untouched
Unified the streaming calls and changed stream validation to use enums
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2220
Co-authors: athul.mallappallil@etas.com, oliver.heilwagen@etas.com, sebastian.lobsinger@etas.com, guruprasad.bhat@etas.com, sunilkumar.prasanchand@etas.com, tibor.zavartkay@etas.com