Update slot count#650
Draft
KrishaDeshkool wants to merge 6 commits into
Draft
Conversation
KrishaDeshkool
force-pushed
the
update_slot_count
branch
12 times, most recently
from
6141762 to
4025188
Compare
A field without a notifier passes a fixed slot count override here. The tracing slots (a std::uint8_t) are added on top the override is small number(2) so the sum cannot overflow, no extra check needed.
…erties It now takes a slot count override and builds the value, so Get no longer fits. Create says it constructs a new SkeletonEventProperties.
KrishaDeshkool
force-pushed
the
update_slot_count
branch
2 times, most recently
from
3b48e9c to
b706d9d
Compare
The field passes its notifier capability to the binding factory, which uses it to pick the slot count for the field's backing event.
KrishaDeshkool
force-pushed
the
update_slot_count
branch
from
b706d9d to
3701ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the slot counts based on this matrix
WithNotifiernumberOfSampleSlots