feat(gateway): Add gateway and transport abstractions#450
Open
Rahul-Sutariya wants to merge 1 commit into
Open
feat(gateway): Add gateway and transport abstractions#450Rahul-Sutariya wants to merge 1 commit into
Rahul-Sutariya wants to merge 1 commit into
Conversation
Rahul-Sutariya
force-pushed
the
gateway_interface
branch
2 times, most recently
from
3a90d34 to
40e58b0
Compare
Introduce score/mw/com/gateway module with: - GatewayCore and Transport interfaces - ServiceElementConfiguration data types - Error domains with comprehensive unit tests - Full Bazel integration
Rahul-Sutariya
force-pushed
the
gateway_interface
branch
from
40e58b0 to
86ddff0
Compare
Rahul-Sutariya
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
crimson11
requested changes
May 20, 2026
| { | ||
|
|
||
| /// \brief Holds size and alignment information for a data type exchanged via the transport layer. | ||
| struct DataTypeSizeInfo |
Contributor
There was a problem hiding this comment.
just saw, that we have score::memory::DataTypeSizeInfo - so we should reuse instead of re-implement here ...
|
|
||
| /// \brief Provide the given service instance locally. | ||
| /// \details This API is expected to be called by the transport layer implementation, when the transport layer | ||
| /// receives a request from the remote gateway to provide a service instance. It shall provide/create the given |
Contributor
There was a problem hiding this comment.
from the remote gateway
from the source gateway
| /// \brief Provide the given service instance locally. | ||
| /// \details This API is expected to be called by the transport layer implementation, when the transport layer | ||
| /// receives a request from the remote gateway to provide a service instance. It shall provide/create the given | ||
| /// service instance locally (e.g. by creating a GenericSkeleton) and offer it. |
Contributor
There was a problem hiding this comment.
service instance locally ...
service instance locally within the destination domain by creating a Forwarding Skeleton (GenericSkeleton) and offer it.
| virtual score::Result<void> ProvideService(impl::InstanceSpecifier service_instance_specifier, | ||
| std::vector<ServiceElementConfiguration> service_elements) = 0; | ||
|
|
||
| /// \brief Stop providing the given service instance locally. |
Contributor
There was a problem hiding this comment.
instance locally.
instance locally within the destination domain.
| /// that this specifier is configured/existent in the mw_com_config.json at the local gateway side. | ||
| virtual void StopOfferService(impl::InstanceSpecifier service_instance_specifier) = 0; | ||
|
|
||
| /// \brief Offer the given service instance locally. |
Contributor
There was a problem hiding this comment.
instance locally within the destination domain.
| /// \return result indicating success or failure. | ||
| virtual score::Result<void> OfferService(impl::InstanceSpecifier service_instance_specifier) = 0; | ||
|
|
||
| /// \brief Register an event-update notification for the given service instance and element locally. |
Contributor
There was a problem hiding this comment.
... locally within the destination domain.
| impl::ServiceElementType element_type, | ||
| std::string element_name) = 0; | ||
|
|
||
| /// \brief Unregister an event-update notification for the given service instance and element locally. |
Contributor
There was a problem hiding this comment.
... locally within the destination domain.
| impl::ServiceElementType element_type, | ||
| std::string element_name) = 0; | ||
|
|
||
| /// \brief Notify an event update for the given service instance and element locally. |
Contributor
There was a problem hiding this comment.
... locally within the destination domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce score/mw/com/gateway module with: