Deduplicate classpath update requests at enqueue time#2366
Open
vogella wants to merge 1 commit into
Open
Conversation
Test Results 129 files ± 0 129 suites ±0 39m 26s ⏱️ + 4m 24s Results for commit 2b88b3f. ± Comparison against base commit 8fbf102. This pull request removes 6 tests.♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
dedup-at-enqueue
branch
from
b0d7e41 to
ab04c78
Compare
vogella
force-pushed
the
dedup-at-enqueue
branch
from
ab04c78 to
4769290
Compare
Member
|
@laeubi do you have remarks on this, since you requested the changes in #2363 (comment)? |
Replace the work queue of UpdateClasspathsJob with a map keyed by project so that deduplication happens structurally when a request is added instead of while draining the queue. This allows UpdateRequest to become private again and removes the drainRequests helper that was made public only for testing, together with the isolated unit tests for it. Addresses review feedback in eclipse-pde#2363
vogella
force-pushed
the
dedup-at-enqueue
branch
from
4769290 to
2b88b3f
Compare
Contributor
Author
|
Any additional feedback here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2363, addressing the review feedback from @laeubi. The work queue of UpdateClasspathsJob is now a map keyed by project, so requests for the same project are merged when they are added rather than while draining the queue. The deduplication is thereby enforced by the data structure itself. This lets UpdateRequest become private again and removes the drainRequests helper that was public only for testing, together with the isolated unit tests for it.