Update starter to include Liberty for Jakarta EE 11 by jhanders34 · Pull Request #382 · eclipse-ee4j/starter

jhanders34 · 2026-05-21T21:17:18Z

Pending compatibility certification issues:

Compatibility certification request for Open Liberty for Jakarta EE 11, Core Profile jakartaee/platform#1288
Compatibility certification request for Open Liberty for Jakarta EE 11, Web Profile jakartaee/platform#1290
Compatibility certification request for Open Liberty for Jakarta EE 11, Platform jakartaee/platform#1292

eclipse-starter-bot · 2026-05-21T21:21:01Z

Can one of the admins verify this patch?

m-reza-rahman · 2026-05-21T21:44:10Z

Once there is actual certification, please take this out of draft mode. I'll review it at that point. Thanks!

jhanders34 · 2026-05-26T03:03:22Z

All CCRs were marked accepted

jhanders34 · 2026-05-28T03:43:39Z

FYI @m-reza-rahman

m-reza-rahman · 2026-05-28T16:10:30Z

I'll take a look ASAP. Currently trying to stabilize a long pending release. Should get to it by the end of the weekend hopefully.

scottkurz · 2026-05-29T14:03:14Z

                                value="Java SE 11 requires Jakarta EE below 11."/>
+                        <h:outputText
+                                styleClass="footnote"
+                                value="Java SE 8 requires Jakarta EE below 10."/>


Minor comment... the "spirit" of the rewording above is to say " EE 10 requires Java SE 11..." rather than "..above 8". By the same token you might say "SE 8 requires EE 9.1 or below" instead of "..below 10".

scottkurz · 2026-05-29T14:04:19Z

+                                value="Jakarta EE 11 requires Java SE 17 or later."/>
+                        <h:outputText
+                                styleClass="footnote"
+                                value="Jakarta EE 10 requires Java SE 11 or later."/>


Noting the others combine the text into one <h:outputText> with a two-sentence value, but I think this is maybe more readable.

Yes, please fix. The same for the next change.

scottkurz

I think you need to change this line..it fails if I actually run mvn archetype:generate and select Open Liberty with EE 11.

archetype-post-generate.groovy: throw new RuntimeException("Failed, only Payara currently supports Jakarta EE 11 in a stable release")

m-reza-rahman · 2026-05-30T17:39:26Z

    #else
        <feature>webProfile-11.0</feature>
    #end
+#else


Please remove this for now. We'll add it when EE 12 is a bit more real.

m-reza-rahman · 2026-05-30T17:40:00Z

        <feature>webProfile-10.0</feature>
    #end
-#else
+#elseif (${jakartaVersion} == '11')


Please remove this. EE 11 can be the fallback case.

m-reza-rahman · 2026-05-30T17:44:55Z

            runtimes.get("glassfish").setDisabled(false);
        }

-        if (jakartaVersion == 11) {


This else-if block can now be removed altogether.

m-reza-rahman · 2026-05-30T17:52:09Z

I think you need to change this line..it fails if I actually run mvn archetype:generate and select Open Liberty with EE 11.
archetype-post-generate.groovy: throw new RuntimeException("Failed, only Payara currently supports Jakarta EE 11 in a stable release")

Yes, this change is entirely missing. The right thing to do at this point is remove the EE 11 catch- all validation and move it to the runtime specific sections. We will need to soon enable GlassFish for EE 11 too, so this change is timely. The correcpionding nightly tests need to be updated as well.

m-reza-rahman

Please address comments. After that, I'll review again.

Copilot

Pull request overview

Enables Open Liberty as a selectable/runtime-tested target for Jakarta EE 11 in the starter UI and archetype outputs, aligning UI guidance and CI coverage with the Jakarta EE 11 Java SE baseline.

Changes:

Updated UI footnotes to explicitly state Java SE requirements for Jakarta EE 10 vs 11, and clarified Java SE 8 constraints.
Allowed Open Liberty to be selectable for Jakarta EE 11 in the UI runtime enablement logic.
Extended Open Liberty archetype config and nightly workflow coverage to include Jakarta EE 11 (Java 17 and 21; full/web/core profiles) with Docker builds.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
`ui/src/main/webapp/index.xhtml`	Updates UI footnotes to reflect Jakarta EE 10/11 Java SE requirements and Java SE 8 constraints.
`ui/src/main/java/org/eclipse/starter/ui/Project.java`	Adjusts runtime enablement so Open Liberty is no longer disabled for Jakarta EE 11.
`archetype/src/main/resources/archetype-resources/src/main/liberty/config/server.xml`	Refines Liberty feature selection logic for Jakarta EE 11 (and adds a fallback for 12).
`.github/workflows/nightly.yml`	Adds nightly archetype + Docker build validation for Jakarta EE 11 on Open Liberty (Java 17 and 21; multiple profiles).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jhanders34 · 2026-06-08T22:10:11Z

@m-reza-rahman and @scottkurz I have addressed your review comments I believe.

m-reza-rahman · 2026-06-08T23:29:51Z

OK, will look ASAP, thanks.

scottkurz

LGTM. Tested the UI and archetype:generate a bit and my comments seem addressed.

m-reza-rahman

LGTM. I’ll take it from here.

jhanders34 · 2026-06-23T16:04:33Z

@m-reza-rahman I see that it is merged, but it appears that start.jakarta.ee hasn't been updated to have the new code deployed. When will that happen?

m-reza-rahman · 2026-06-23T16:40:34Z

We also need to update for GlassFish. Probably in a few weeks?

m-reza-rahman · 2026-06-23T19:22:59Z

Also, @jhanders34 - it looks like the merge has broken the nightly build: https://github.com/eclipse-ee4j/starter/actions/runs/27994183766/job/82852778584. Can you kindly take a look? Otherwise, this is one more thing I need to do.

jhanders34 · 2026-06-23T20:42:18Z

Also, @jhanders34 - it looks like the merge has broken the nightly build: https://github.com/eclipse-ee4j/starter/actions/runs/27994183766/job/82852778584. Can you kindly take a look? Otherwise, this is one more thing I need to do.

@m-reza-rahman I created PR #383 which should resolve this issue.

m-reza-rahman · 2026-06-23T20:45:27Z

Merged. Hopefully that was it.

jhanders34 · 2026-06-24T14:51:20Z

Merged. Hopefully that was it.

Last night's nightly build was good.

Update start to include Liberty for Jakarta EE 11

ca6a503

jhanders34 force-pushed the jha_branch1 branch from 017c557 to ca6a503 Compare May 21, 2026 21:41

m-reza-rahman marked this pull request as draft May 21, 2026 21:41

jhanders34 marked this pull request as ready for review May 26, 2026 03:03

ivargrimstad approved these changes May 28, 2026

View reviewed changes

m-reza-rahman self-assigned this May 28, 2026

scottkurz reviewed May 29, 2026

View reviewed changes

scottkurz suggested changes May 29, 2026

View reviewed changes

m-reza-rahman reviewed May 30, 2026

View reviewed changes

m-reza-rahman requested changes May 30, 2026

View reviewed changes

m-reza-rahman requested a review from Copilot May 30, 2026 17:54

Copilot started reviewing on behalf of m-reza-rahman May 30, 2026 17:54 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

Review updates

3666eb1

jhanders34 force-pushed the jha_branch1 branch from 4385a69 to 3666eb1 Compare June 8, 2026 22:08

jhanders34 requested review from m-reza-rahman and scottkurz June 8, 2026 22:10

scottkurz approved these changes Jun 10, 2026

View reviewed changes

m-reza-rahman approved these changes Jun 13, 2026

View reviewed changes

m-reza-rahman merged commit 60a5503 into eclipse-ee4j:master Jun 13, 2026
3 checks passed

Uh oh!

Conversation

jhanders34 commented May 21, 2026

Uh oh!

eclipse-starter-bot commented May 21, 2026

Uh oh!

m-reza-rahman commented May 21, 2026

Uh oh!

jhanders34 commented May 26, 2026

Uh oh!

jhanders34 commented May 28, 2026

Uh oh!

m-reza-rahman commented May 28, 2026

Uh oh!

scottkurz May 29, 2026

Choose a reason for hiding this comment

Uh oh!

scottkurz May 29, 2026

Choose a reason for hiding this comment

Uh oh!

m-reza-rahman May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scottkurz left a comment

Choose a reason for hiding this comment

Uh oh!

m-reza-rahman May 30, 2026

Choose a reason for hiding this comment

Uh oh!

m-reza-rahman May 30, 2026

Choose a reason for hiding this comment

Uh oh!

m-reza-rahman May 30, 2026

Choose a reason for hiding this comment

Uh oh!

m-reza-rahman commented May 30, 2026

Uh oh!

m-reza-rahman left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

jhanders34 commented Jun 8, 2026

Uh oh!

m-reza-rahman commented Jun 8, 2026

Uh oh!

scottkurz left a comment

Choose a reason for hiding this comment

Uh oh!

m-reza-rahman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jhanders34 commented Jun 23, 2026

Uh oh!

m-reza-rahman commented Jun 23, 2026

Uh oh!

m-reza-rahman commented Jun 23, 2026

Uh oh!

jhanders34 commented Jun 23, 2026

Uh oh!

m-reza-rahman commented Jun 23, 2026

Uh oh!

jhanders34 commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

m-reza-rahman May 30, 2026 •

edited

Loading