Support jsign without google cloud platform#607
Open
bschwert wants to merge 3 commits into
Open
Conversation
mbarbero
requested changes
Jul 3, 2026
| */ | ||
| @AutoValue | ||
| public abstract class JSigner implements CodeSigner { | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| private static final Logger logger = LoggerFactory.getLogger(JSigner.class); | |
| import java.nio.file.Path; | ||
| import java.security.KeyStore; | ||
| import java.util.List; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| import org.slf4j.Logger; | |
| import org.slf4j.LoggerFactory; |
| keyStoreBuilder.certfile(configuration().getCertificateChain().toFile()); | ||
| } | ||
| } catch(IllegalArgumentException e){ | ||
| // Ignore missing certficate chain;could be stored in keystore |
Member
There was a problem hiding this comment.
Suggested change
| // Ignore missing certficate chain;could be stored in keystore | |
| logger.warn("An error occurred while building the certfile. This could be due to missing intermediate certificates that may already be stored in the keystore.", e); |
Member
|
Thank you for the contribution and for your patience for the long overdue review. Please look the suggested changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no
kmsCredentialscredentials are provided jsign can also use a PKCS#11 keystore and a storepass.