Add proper pagination#16
Merged
Merged
Conversation
Note that this is still missing proper pagination tokens. This is the most basic implementation, vulnerable to change in data between requests
s-heppner
requested changes
Jun 20, 2025
s-heppner
left a comment
s-heppner
left a comment
Member
There was a problem hiding this comment.
Other than these small style fixes, this LGTM. Thank you!
s-heppner
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original implementation basic limits on request were supported with the
@limiteddecorator.These changes improve pagination to support cursors as specified, providing a proper (basic) pagination with client side cursor handling.