fix: bullet/number lost when list item starts with linebreak in pdf#10045
Open
BacLuc wants to merge 1 commit into
Open
fix: bullet/number lost when list item starts with linebreak in pdf#10045BacLuc wants to merge 1 commit into
BacLuc wants to merge 1 commit into
Conversation
…ecamp#3986) The PDF RichText component prepended the bullet (•) or number by directly modifying node.children[0].children[0].content. When a <br> appeared as the first child of a <li> (e.g. <li><br>text</li>), that <br> tag has no content property so the prefix was silently lost. Replace the hardcoded path with a recursive prependTextContent() helper that traverses the child tree depth-first to find the first actual text node, skipping over <br> and other non-text tags. Update snapshots for the empty-list case which now correctly shows the bullet. Fixes ecamp#3986 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Feature branch deployment ready!
|
BacLuc
added
deploy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDF RichText component prepended the bullet (•) or number by directly modifying node.children[0].children[0].content. When a
appeared as the first child of a
text
tag has no content property so the prefix was silently lost.
Replace the hardcoded path with a recursive prependTextContent() helper that traverses the child tree depth-first to find the first actual text node, skipping over
and other non-text tags. Update snapshots for the empty-list case which now correctly shows the bullet.
Fixes #3986