Standardize dirty flag#211
Merged
Merged
Conversation
henrikjacobsenfys
added
[scope] maintenance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #211 +/- ##
==========================================
Coverage ? 97.99%
==========================================
Files ? 52
Lines ? 3639
Branches ? 650
==========================================
Hits ? 3566
Misses ? 41
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was
linked to
issues
Jun 18, 2026
rozyczko
reviewed
Jun 19, 2026
rozyczko
left a comment
rozyczko
left a comment
Member
There was a problem hiding this comment.
Minor issue raised.
Also, consider removing .claude directory from pushed content
Every user/dev interested will recreate it with their own setup by running claude init
Comment on lines
+205
to
+209
| if ( | ||
| self.sample_model._component_collections_is_dirty # noqa: SLF001 | ||
| or self.instrument_model.resolution_model._component_collections_is_dirty # noqa: SLF001 | ||
| ): | ||
| self._convolver_is_dirty = True |
Member
There was a problem hiding this comment.
This is querying two other objects' private dirty flags. It works, but aren't we trying to actually remove this behaviouir?
Consider exposing a public is_dirty/needs_rebuild on ModelBase, or having those mutations notify subscribers. At minimum, a comment explaining why this particular query is needed would help.
…check - Add ModelBase.component_collections_is_dirty public property so Analysis1d.fit() no longer accesses private attributes on external objects - Replace _prospective_Q_len pre-check in Analysis.rebin() with a post-rebin np.allclose comparison (same logic as ModelBase.Q setter), catching Q value changes even when count stays the same; rolls back _binned_data if confirm=True is not given - Remove .claude/ from git tracking and add to .gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes how to deal with changes to e.g. Q, adding components etc., to always prefer flagging as dirty and rebuilding lazily.
Also a bunch of minor cleanups.