Skip to content

Add data_and_model_to_datagroup method#176

Merged
henrikjacobsenfys merged 7 commits into
developfrom
calculate-model-in-analysis
May 8, 2026
Merged

Add data_and_model_to_datagroup method#176
henrikjacobsenfys merged 7 commits into
developfrom
calculate-model-in-analysis

Conversation

@henrikjacobsenfys

Copy link
Copy Markdown
Member

This allows users to easily extract the data and all components in the model for customising their plots.
Closes #171

@henrikjacobsenfys henrikjacobsenfys added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] medium Normal/default priority labels May 7, 2026
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.12%. Comparing base (6cc5b8d) to head (161c47e).

Files with missing lines Patch % Lines
src/easydynamics/analysis/analysis.py 93.54% 1 Missing and 1 partial ⚠️
src/easydynamics/analysis/analysis1d.py 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
+ Coverage    98.05%   98.12%   +0.06%     
===========================================
  Files           45       45              
  Lines         2825     2874      +49     
  Branches       496      511      +15     
===========================================
+ Hits          2770     2820      +50     
- Misses          33       34       +1     
+ Partials        22       20       -2     
Flag Coverage Δ
integration 48.15% <4.54%> (-0.77%) ⬇️
unittests 98.12% <95.45%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrikjacobsenfys henrikjacobsenfys linked an issue May 7, 2026 that may be closed by this pull request

@rozyczko rozyczko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential validation issues raised.

Comment thread src/easydynamics/analysis/analysis1d.py
Comment thread src/easydynamics/analysis/analysis1d.py
@henrikjacobsenfys henrikjacobsenfys requested a review from rozyczko May 8, 2026 04:14

@rozyczko rozyczko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@henrikjacobsenfys henrikjacobsenfys merged commit cd12997 into develop May 8, 2026
33 of 34 checks passed
@henrikjacobsenfys henrikjacobsenfys deleted the calculate-model-in-analysis branch June 3, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] medium Normal/default priority [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it easy to extract data and model for plotting

2 participants