Add ParameterAnalysis#167
Merged
Merged
Conversation
henrikjacobsenfys
added
[scope] enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
+ Coverage 98.12% 98.18% +0.06%
===========================================
Files 45 47 +2
Lines 2874 3137 +263
Branches 511 568 +57
===========================================
+ Hits 2820 3080 +260
- Misses 34 35 +1
- Partials 20 22 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Closed
rozyczko
reviewed
May 5, 2026
rozyczko
left a comment
rozyczko
left a comment
Member
There was a problem hiding this comment.
Well written functionality. Just a few minor comments
Comment on lines
+96
to
+97
| def bindings(self) -> list[FitBinding] | None: | ||
| """ |
Member
There was a problem hiding this comment.
self._binding is always a list
def _verify_bindings(self, bindings: FitBinding | list[FitBinding] | None) -> list[FitBinding]:so | None is wrong here.
Comment on lines
+23
to
+24
| FIT_FUNCTION_TYPE = ModelComponent | ComponentCollection | DiffusionModelBase | ||
|
|
Member
There was a problem hiding this comment.
This seems to be unused. Consider removing
Comment on lines
+30
to
+31
| Can be used to fit paramters to ModelComponents, ComponentCollections, or DiffusionModelBase | ||
| objects, and to plot the parameters and fit results. The parameters to be analyzed can be |
Member
Author
|
@AndrewSazonov Do you know why these tests fail? All I did was merge develop (tests failed), pixi update and pixi run fix... The tests worked on the branch that was merged into develop, so I have no idea what went wrong.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fit the fit result from
Analysisto either aModelComponent,ComponentCollectionorDiffusionModel.