Fix bug when plotting data with a single Q value#158
Merged
Conversation
henrikjacobsenfys
added
[scope] bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #158 +/- ##
========================================
Coverage 97.86% 97.86%
========================================
Files 42 42
Lines 2617 2621 +4
Branches 453 453
========================================
+ Hits 2561 2565 +4
Misses 33 33
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henrikjacobsenfys
changed the title
rozyczko
approved these changes
Apr 20, 2026
rozyczko
left a comment
rozyczko
left a comment
Member
There was a problem hiding this comment.
Looks good! Minor suggestion, but nothing blocking.
Comment on lines
+679
to
+681
| if len(datasets) == 1: | ||
| ds = ds.assign_coords(Q=self.Q) | ||
|
|
Member
There was a problem hiding this comment.
Instead of special-casing len(datasets) == 1, you could assign Q coordinates unconditionally:
ds = sc.concat(datasets, dim='Q')
ds = ds.assign_coords(Q=self.Q)
return dsThis would be correct for all Q counts and eliminate the branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small issue found today when working with data with a single Q value.