Allow normalising the resolution function#140
Merged
Conversation
henrikjacobsenfys
added
[scope] enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #140 +/- ##
========================================
Coverage 97.74% 97.75%
========================================
Files 37 37
Lines 2486 2493 +7
Branches 421 422 +1
========================================
+ Hits 2430 2437 +7
Misses 32 32
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rozyczko
approved these changes
Mar 26, 2026
rozyczko
left a comment
rozyczko
left a comment
Member
There was a problem hiding this comment.
Other than a small nitpick, this is ready to merge
Comment on lines
+372
to
+373
| assert total_area == 1.0 | ||
|
|
Member
There was a problem hiding this comment.
Maybe pytest.approx(1.0) so you don't compare floats explicitly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to normalise the resolution function to have area 1.
The ideal solution does not modify the
resolution_modeldirectly but instead uses a copy. However, copy is currently broken and requires quite a bit of work to be fixed (will happen after moving to EasyList), and so this is an intermediate fix.Closes #138