Implement exponential function#130
Conversation
henrikjacobsenfys
added
[scope] enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #130 +/- ##
==========================================
Coverage ? 97.75%
==========================================
Files ? 37
Lines ? 2408
Branches ? 399
==========================================
Hits ? 2354
Misses ? 34
Partials ? 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
Looks very good!
I made some nitpicking comments, though :)
| Raises: | ||
| TypeError: If amplitude, center, or rate are not numbers or | ||
| Parameters. | ||
| ValueError: If rate is not positive. |
There was a problem hiding this comment.
there is only a check for type and for finiteness (lines 104 and 89). No check is being made for positiveness.
Please update the docstring
| display_name (str | None): Name of the component. unique_name | ||
| (str | None): Unique name of the component. |
There was a problem hiding this comment.
unique_name should be moved to the line below
| # Attempt to rollback on failure | ||
| try: | ||
| for p in pars: | ||
| if hasattr(p, 'convert_unit'): |
There was a problem hiding this comment.
I don't think this check is necessary. p is always a Parameter with all the methods.
2 participants
Every user* so far has requested this and needs it to fit their data.