Skip to content

Clearer fit modes that match your loaded data#207

Merged
AndrewSazonov merged 26 commits into
developfrom
dataset-driven-fit-modes
Jun 17, 2026
Merged

Clearer fit modes that match your loaded data#207
AndrewSazonov merged 26 commits into
developfrom
dataset-driven-fit-modes

Conversation

@AndrewSazonov

Copy link
Copy Markdown
Member

EasyDiffraction now offers only the fitting modes that make sense for what you have loaded: with one dataset you get a normal single fit (and can switch to a sequential scan over a folder of files); with several datasets you get a combined (joint) fit. This removes a confusing case where fitting several datasets one-by-one could make earlier datasets plot incorrectly.

Sequential scans are also clearer to set up — you get a clear message when no data files are found, and a new option can copy the scanned files into your project so it stays self-contained and portable.

@AndrewSazonov AndrewSazonov added the [scope] enhancement Adds/improves features (major.MINOR.patch) label Jun 17, 2026
@AndrewSazonov AndrewSazonov merged commit db2c9e9 into develop Jun 17, 2026
18 of 21 checks passed
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (62d5b52) to head (6f2b8c6).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/easydiffraction/analysis/analysis.py 90.16% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
+ Coverage    90.32%   90.33%   +0.01%     
===========================================
  Files          283      283              
  Lines        24181    24207      +26     
  Branches      2835     2840       +5     
===========================================
+ Hits         21842    21868      +26     
  Misses        1743     1743              
  Partials       596      596              
Flag Coverage Δ
unittests 90.33% <92.94%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...action/analysis/categories/fitting_mode/default.py 100.00% <100.00%> (ø)
...tion/analysis/categories/sequential_fit/default.py 100.00% <100.00%> (ø)
src/easydiffraction/display/plotting.py 89.91% <100.00%> (-0.13%) ⬇️
src/easydiffraction/analysis/analysis.py 93.13% <90.16%> (+0.17%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant