Clearer fit modes that match your loaded data#207
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #207 +/- ##
===========================================
+ Coverage 90.32% 90.33% +0.01%
===========================================
Files 283 283
Lines 24181 24207 +26
Branches 2835 2840 +5
===========================================
+ Hits 21842 21868 +26
Misses 1743 1743
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EasyDiffraction now offers only the fitting modes that make sense for what you have loaded: with one dataset you get a normal single fit (and can switch to a sequential scan over a folder of files); with several datasets you get a combined (joint) fit. This removes a confusing case where fitting several datasets one-by-one could make earlier datasets plot incorrectly.
Sequential scans are also clearer to set up — you get a clear message when no data files are found, and a new option can copy the scanned files into your project so it stays self-contained and portable.