Fix duplicate counting of progress in obtain_file#5174
Open
Flamefire wants to merge 1 commit into
Open
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
Open
`obtain_file` calls `obtain_file_raise_on_failure` but both are wrapped in a decorator that increases the progress of the RICH progressbar. This causes it to be incremented twice for each file. Add a test for the `fetch_step` which also verifies this behavior.
Flamefire
force-pushed
the
double-file-progress
branch
from
48b8fed to
3a94983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
obtain_filecallsobtain_file_raise_on_failurebut both are wrapped in a decorator that increases the progress of the RICH progressbar. This causes it to be incremented twice for each file.Add a test for the
fetch_stepwhich also verifies this behavior.Note that I'm using
unittest.mockto verify the progressbar calls and avoid actually downloading anything.