fix: replace direct CSS import with CSS-in-JS styling#1
Merged
Conversation
Grafana's plugin validator rejects direct CSS imports (code-rules-no-direct-css-imports). Move the rules from styles.css into emotion CSS-in-JS via useStyles2, and render the diff as React elements instead of injecting an HTML string through dangerouslySetInnerHTML (which also removes the need for manual HTML escaping). Bump to 1.0.1. Co-authored-by: Cursor <cursoragent@cursor.com>
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded No assets were added Removed No assets were removed Bigger
Smaller
View module informationAdded No modules were added Removed
Bigger
Smaller No modules were smaller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-rules-no-direct-css-imports— a directimport './styles.css'insrc/panel/TextDiffPanel.tsx.styles.cssinto emotion CSS-in-JS viauseStyles2, and render the diff as React elements (usingcxfor added/removed lines) instead of building an HTML string fordangerouslySetInnerHTML— which also removes the manualescapeHtmlhelper.src/panel/styles.cssand bumped the plugin to1.0.1.Validation
npm run typecheck,npm run lint,npm run build, andnpm run test:ciall pass.grafana/plugin-validator-cli) against a built zip + source: exits0, andcode-rulesnow reports "no code rules violations found". Only the expected unsigned-plugin warning and an optional sponsorship-link recommendation remain.1.0.1to local Grafana and confirmed the panel registers and renders, with zerostyles.cssreferences in the servedmodule.js.Test plan
Made with Cursor