Do not use CTRL+C to close the app, only use quit/exit#137
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 62.37% 62.17% -0.21%
==========================================
Files 65 65
Lines 1858 1864 +6
Branches 534 535 +1
==========================================
Hits 1159 1159
- Misses 379 384 +5
- Partials 320 321 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Carlosespicur
suggested changes
May 20, 2025
a4f3b37 to
f243ccd
Compare
Carlosespicur
previously approved these changes
May 21, 2025
Test with DDS Router and DDS Recorder tools first
rsanchez15
requested changes
May 21, 2025
rsanchez15
left a comment
Collaborator
There was a problem hiding this comment.
Update this section in docs
https://fast-dds-spy.readthedocs.io/en/latest/rst/user_manual/tool.html#close-application
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
f243ccd to
e1003b8
Compare
Contributor
Author
Carlosespicur
approved these changes
May 21, 2025
rsanchez15
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids using CTRL+C in fastddsspy to close the application.
Merge after: