[#24316] Reduced InstanceCache key warning spam#144
Merged
Conversation
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 62.27% 56.73% -5.54%
==========================================
Files 29 28 -1
Lines 2502 1960 -542
Branches 1070 772 -298
==========================================
- Hits 1558 1112 -446
+ Misses 382 367 -15
+ Partials 562 481 -81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes repeated
FASTDDSSPY_INSTANCECACHEwarnings caused by missing key metadata on incoming DynamicTypes, while preserving current key-caching behavior.Changes
InstanceCache::add_or_update_instance:InstanceCache.Related PR Display the list of keys in a topic