- Update MongoDB library to v2.1 and adjust Composer dependency#43
Closed
borsuk85 wants to merge 2 commits into
Closed
- Update MongoDB library to v2.1 and adjust Composer dependency#43borsuk85 wants to merge 2 commits into
borsuk85 wants to merge 2 commits into
Conversation
- Update Dockerfile with MongoDB extension v2.1.1 - Implement CursorInterface mock for improved test compatibility - Refactor `all` method in `MongoTransport` to return `\Traversable`
iosifch
requested changes
Aug 25, 2025
| } | ||
|
|
||
| public function all(int $limit = null): iterable | ||
| public function all(int $limit = null): \Traversable |
Member
There was a problem hiding this comment.
The ListableReceiverInterface is defined with iterable. Why not keeping iterable?
Author
There was a problem hiding this comment.
8.2.0 The type of iterator has been widened from Traversable to Traversable|array.
Before 8.2 should be \Traversable
Author
There was a problem hiding this comment.
MongoTransportTest uses $collection = iterator_to_array($transport->all(2));
Member
There was a problem hiding this comment.
still i don't get why MongoTransport should not respect the interface it implements.
iosifch
reviewed
Oct 8, 2025
| } | ||
|
|
||
| /** | ||
| * Zwraca prosty kursor zgodny z MongoDB\Driver\CursorInterface, |
Member
There was a problem hiding this comment.
don't forget to remove the comments
Member
|
I decided to make a new pull request (#45) where I implemented most of the changes you made in this pull request because I had to make several more updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allmethod inMongoTransportto return\Traversable