Skip to content

converted code to Tensorflow 1 and changed skimage range#27

Open
martinosorb wants to merge 1 commit into
dyelax:masterfrom
martinosorb:tf1
Open

converted code to Tensorflow 1 and changed skimage range#27
martinosorb wants to merge 1 commit into
dyelax:masterfrom
martinosorb:tf1

Conversation

@martinosorb

Copy link
Copy Markdown

The code was converted using automatic conversion provided by Tensorflow.

Additionally, the most recent skimage was telling me its images needed to be between -1 and 1, the opposite of what your code and comments said. I changed that, adding a clip since some values were (very slightly) larger than 1.0. This is slightly suspicious...

Note: I also have a python 3 version, which is NOT included in this PR, but you may be interested in.

@dyelax

dyelax commented Jul 19, 2018

Copy link
Copy Markdown
Owner

Thanks for the PR! Honestly I haven't touched this repo in a while so I'll need to re-download the data, but I'll try to test this and merge this weekend

@dyelax

dyelax commented Jul 19, 2018

Copy link
Copy Markdown
Owner

Would also definitely be interested in your Python 3 version!

@martinosorb

Copy link
Copy Markdown
Author

Great, however if I push the py3, it may not be compatible with py2 anymore. Is that ok?

@dyelax

dyelax commented Jul 21, 2018

Copy link
Copy Markdown
Owner

What did you change to make it work with python3? I’d love to have it be cross-compatible if possible

@martinosorb

Copy link
Copy Markdown
Author

I used 2to3, which does it automatically, and then ran it to check it worked (I had to make one more change before it did). The 2to3 docs state it's usually not a good idea to try making code compatible with both 2 and 3, but that's up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants