Skip to content

fix: sign in#1890

Merged
culshawn merged 8 commits into
mainfrom
fix/gov-sign-in-tm-confirmation-handling
Jun 1, 2026
Merged

fix: sign in#1890
culshawn merged 8 commits into
mainfrom
fix/gov-sign-in-tm-confirmation-handling

Conversation

@sr4850

@sr4850 sr4850 commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

Related issue: JIRA_TICKET_NUMBER

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

sr4850 and others added 2 commits May 28, 2026 12:05
Added handling for 'You have already proved your identity' and
'Confirm your details' pages at the end of signInGovAccount() so
all callers benefit. Also added handling in operator countersigns
steps in TmVerifyDifferentOperator.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…count

The 'Confirm your details' page appears before 'Continue to the
service' button check. Since that check triggers an early return
when the button isn't found, the handling at the end was never
reached. Moved the checks to before the early return point.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Operator

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@culshawn culshawn merged commit 2a7b046 into main Jun 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants