feat: add contract tests for olcs-transfer API alignment#168
Merged
Conversation
Add 76 contract tests validating enum values and builder JSON
serialisation against the olcs-transfer API contract:
- EnumContractTest: validates all 13 enums (81 constants) match
olcs-transfer InArray validators
- BuilderContractTest: validates JSON field names for Application,
Address, ContactDetails, Person, and TrackingBuilder
Fix BusinessType.OTHER leading space bug caught by contract tests
(' org_t_pa' → 'org_t_pa').
Add contract-tests.yaml workflow triggered by:
- Pull requests (catches vol-api-calls changes)
- repository_dispatch (triggered by olcs-transfer on merge to main)
- Weekly schedule (safety net)
Add junit-jupiter test dependency to align engine version with
API provided transitively by active-support.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
culshawn
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 76 contract tests validating enum values and builder JSON serialisation against the olcs-transfer API contract:
Fix BusinessType.OTHER leading space bug caught by contract tests (' org_t_pa' → 'org_t_pa').
Add contract-tests.yaml workflow triggered by:
Add junit-jupiter test dependency to align engine version with API provided transitively by active-support.
Description
Related issue: JIRA_TICKET_NUMBER
Before submitting (or marking as "ready for review")