Skip to content

feat: add validation loop to prevent postcode errors #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sr4850 merged 1 commit into from
Nov 7, 2025
Merged

feat: add validation loop to prevent postcode errors #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/main/java/apiCalls/enums/TrafficArea.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.apache.commons.lang3.RandomStringUtils;
import java.util.Random;
import java.util.regex.Pattern;

public enum TrafficArea {
NORTH_EAST("B"),
Expand All @@ -16,6 +17,8 @@ public enum TrafficArea {

private final String trafficAreas;
static Random random = new Random();
private static final Pattern POSTCODE_VALIDATION_PATTERN = Pattern.compile("^[a-zA-Z0-9 ]+$");
private static final int MAX_POSTCODE_GENERATION_ATTEMPTS = 3;

private TrafficArea(String trafficAreas) {
this.trafficAreas = trafficAreas;
Expand All @@ -26,6 +29,37 @@ public String value() {
}

public static String getPostCode(TrafficArea trafficArea) {
String postCode;
int attempts = 0;

while (attempts < MAX_POSTCODE_GENERATION_ATTEMPTS) {
postCode = generatePostCodeInternal(trafficArea);

if (isValidPostcode(postCode)) {
return postCode;
}

attempts++;
System.err.println(String.format(
"Generated postcode '%s' failed validation (attempt %d/%d). Retrying...",
postCode, attempts, MAX_POSTCODE_GENERATION_ATTEMPTS
));
}

throw new IllegalStateException(
String.format("Failed to generate valid postcode for %s after %d attempts",
trafficArea, MAX_POSTCODE_GENERATION_ATTEMPTS)
);
}

public static boolean isValidPostcode(String postcode) {
if (postcode == null || postcode.isEmpty()) {
return false;
}
return POSTCODE_VALIDATION_PATTERN.matcher(postcode).matches();
}

private static String generatePostCodeInternal(TrafficArea trafficArea) {
String postCode;
switch (trafficArea) {
case NORTH_EAST:
Expand Down