Mes 8325 missing certs2#297
Draft
andrewsetterfield wants to merge 16 commits into
Draft
Conversation
WIP restore UTC updated local testing added logic for spoiled certificates added staff numbers to payload and removed check digit refactor code out of handler
andrewsetterfield
force-pushed
the
mes-8325-missing-certs2
branch
from
7fb9613 to
32d37d1
Compare
…it from missing certificates query as this serves no purpose and is preventing union from spoiled certificate where its not going to be available
matthew2564
reviewed
Jul 14, 2023
matthew2564
reviewed
Jul 14, 2023
Collaborator
|
Maybe could with renaming handlers // Duplicating the word certificate feels needless, so we could do // The other // Just to be consistent with the new format |
matthew2564
reviewed
Jul 14, 2023
matthew2564
reviewed
Jul 14, 2023
andrewsetterfield
force-pushed
the
mes-8325-missing-certs2
branch
from
b093cae to
1ee9703
Compare
relax UTC timestamp test relax UTC timestamp test
andrewsetterfield
force-pushed
the
mes-8325-missing-certs2
branch
from
1ee9703 to
e613a2f
Compare
matthew2564
reviewed
Jul 24, 2023
matthew2564
reviewed
Jul 24, 2023
matthew2564
reviewed
Jul 24, 2023
|
|
||
| // Specify that dates should be serialised in UTC. | ||
| return mysql.format(template, args, false, 'UTC'); | ||
| return mysql.format(template, args); |
Collaborator
There was a problem hiding this comment.
Hmm, this upgrade will have an impact on the timestamp of the test by the looks of it as per with the unit test here src/functions/postResult/framework/database/__tests__/query-builder.spec.ts.
Do we need to update the SQL to do this if the package no longer accepts a timezone?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and relevant Jira numbers
Pull Request checklist
Git feature branch checklist
Sign off process checklist