Skip to content

security/igtf-certificates @1.52: update to 1.54 and some other changes#13

Open
petrrr wants to merge 8 commits into
dvandok:macportsfrom
petrrr:macports
Open

security/igtf-certificates @1.52: update to 1.54 and some other changes#13
petrrr wants to merge 8 commits into
dvandok:macportsfrom
petrrr:macports

Conversation

@petrrr

@petrrr petrrr commented Nov 14, 2013

Copy link
Copy Markdown
Contributor

Further changes:

  • add license, long_description, livecheck, documentation;
  • some editing;

The port should be okay for submission to Macports. I would propose to submit it as it is and ask for further feedback. It is quite independent of the Globus TK stack.

If you are okay with this I could proceed, just let me know.

@petrrr

petrrr commented Nov 14, 2013

Copy link
Copy Markdown
Contributor Author

I thought there is a way to select commits, I wanted to include only the relevant one. Is there a way to edit this PR now? Or to I need to restart?

@dvandok

dvandok commented Nov 14, 2013

Copy link
Copy Markdown
Owner

On 14-11-13 22:46, petrrr wrote:

I thought there is a way to select commits, I wanted to include only the relevant one. Is there a way to edit this PR now? Or to I need to restart?

That's ok; I guess that's just the way github works. I'll cherry pick
the relevant changes.

Cheers,

Dennis

@petrrr

petrrr commented Nov 14, 2013

Copy link
Copy Markdown
Contributor Author

Thanks!
BTW: I already prepared & tested 1.55 as well, but I'll wait with this until it is released.

@dvandok

dvandok commented Nov 14, 2013

Copy link
Copy Markdown
Owner

Where did you find 1.55 !?

@petrrr

petrrr commented Nov 14, 2013

Copy link
Copy Markdown
Contributor Author

It is probably a release candidate, so I'd better not disclose the address here, before it is officially released.
I was asked to have a look at it by David Groep (he is a colleague of you, right?).

@dvandok

dvandok commented Nov 14, 2013

Copy link
Copy Markdown
Owner

On 14-11-13 23:20, petrrr wrote:

It is probably a release candidate, so I'd better not disclose the address here, before it is officially released.
I was asked to have a look at it by David Groep (he is a colleague of you, right?).

Yes, it's OK then. ;-)

@petrrr

petrrr commented Nov 19, 2013

Copy link
Copy Markdown
Contributor Author

Dennis should I submit this for review, by Macports developers?

@dvandok

dvandok commented Nov 19, 2013

Copy link
Copy Markdown
Owner

On 19-11-13 21:23, petrrr wrote:

Dennis should I submit this for review, by Macports developers?

yes, please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants