feat(stays): add chain_id support and NegotiatedRates module#1164
Merged
Conversation
jekku
force-pushed
the
jek/chain-related-stays-changes
branch
from
87d50cc to
39aff65
Compare
- Add `id` field to `StaysChain` interface for chain identification - Add `NegotiatedRates` module with full CRUD operations: - create (with chain_id or accommodation_ids) - get, update, list, listWithGenerator, delete - Add types: `StaysNegotiatedRate`, create/update payload types - Add `MOCK_CHAIN` and `MOCK_NEGOTIATED_RATE` test fixtures - Update `MOCK_ACCOMMODATION` to reference `MOCK_CHAIN` Co-authored-by: Cursor <cursoragent@cursor.com>
jekku
force-pushed
the
jek/chain-related-stays-changes
branch
from
1478313 to
4b6f89d
Compare
burrt
reviewed
May 26, 2026
| * Payload for creating a negotiated rate associated with a chain. | ||
| * You must provide either chain_id or accommodation_ids, but not both. | ||
| */ | ||
| export interface StaysNegotiatedRateCreatePayloadWithChain { |
There was a problem hiding this comment.
minor: I think in TS you can use extends on interfaces so you won't have to repeat rate_access_code and display_name but not sure if you intentionally did this
Contributor
Author
There was a problem hiding this comment.
this should be intentional. but there is something wrong here. you can't update the rac.
burrt
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idfield toStaysChaininterface to support chain identification in accommodation responsesNegotiatedRatesmodule with full CRUD operations based on API docs:create- with eitherchain_idoraccommodation_ids(mutually exclusive)get,update,list,listWithGenerator,deleteStaysNegotiatedRate,StaysNegotiatedRateCreatePayload,StaysNegotiatedRateUpdatePayloadMOCK_CHAINandMOCK_NEGOTIATED_RATEtest fixturesChanges
StaysTypes.tsidtoStaysChain, added all negotiated rate typesStays.tsnegotiatedRatesresourceNegotiatedRates/mocks.tsMOCK_CHAIN,MOCK_NEGOTIATED_RATE, updatedMOCK_ACCOMMODATIONTest plan
chain_idandaccommodation_idsvariants for create/updateMade with Cursor