Upgrade Node and a few dependencies to address security vulnerabilities#1149
Merged
2 commits merged intoApr 20, 2026
Merged
Conversation
andrejak
commented
Apr 20, 2026
andrejak
commented
Contributor
- Bumps a few dependencies in the lockfile
- Bumps Node engine to 20 and upgrades @rollup/plugin-terser to 1.0.0
andrejak
changed the title
igorp1
reviewed
Apr 20, 2026
| @@ -1 +1 @@ | |||
| nodejs 18.20.8 No newline at end of file | |||
Contributor
There was a problem hiding this comment.
This makes me think we should bump it in assistant too (or maybe even switch assistant to bun -- considering it has no production runtime, it'd be just for benefit of dev really)
Comment on lines
100
to
+101
| "engines": { | ||
| "node": ">=18.*" | ||
| "node": ">=20" |
Contributor
There was a problem hiding this comment.
If we change this, would people using this version on node 18 begin to experience failure to install?
Can we bump tools versions and maintain the minimum engine on 18?
andrejak
deleted the
andreja/tsp-1310-resolve-security-vulnerabilities-on-public-sdk-repo-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.