Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
malmstein
marked this pull request as draft
September 21, 2026 10:47
malmstein
marked this pull request as ready for review
September 21, 2026 11:27
Behind updatedPickers, the picker now splits models into what the user can use and what is gated, separated by a divider, instead of grouping them into Plus and Pro tiers. Gated rows carry the follow-up ellipsis since tapping one opens an upsell rather than picking a model, and rows show the backend label as a subline. The gated header names what unlocks the section: Pro when every gated model needs Pro, otherwise the free trial when the user can still start one, otherwise a plain subscriber header. Free trial eligibility comes from the subscriptions API and is new in ModelState. Copy lives in donottranslate until it is signed off, and the old tier headers stay for the flag-off path until the flag is retired. https://app.asana.com/1/137249556945/task/1218304469640062 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Rows without a subline came out around 38dp, shorter than the design and below the 48dp touch target, while rows with one already cleared it. A minimum height levels the short rows up without stretching the two-line ones. https://app.asana.com/1/137249556945/task/1218304469640062 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
malmstein
force-pushed
the
feature/david/model_picker_ui
branch
from
September 21, 2026 14:42
1a10ef8 to
2bfa342
Compare
6 tasks
malmstein
added this pull request to stack #9820
September 21, 2026 14:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1218304469640062
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable): None
Description
Behind
updatedPickers, the model picker groups by what the user can actually use rather thanby tier: one section of available models, a divider, then the gated ones. Gated rows get the
follow-up ellipsis because tapping one opens an upsell instead of picking a model, and rows
render the backend
labelas a subline.Rows also get a 48dp minimum height, since rows without a subline were coming out around 38dp, shorter than the design and below the touch-target minimum.
The gated header names what unlocks the section: Pro when every gated model needs Pro,
otherwise the free trial when the user can still start one, otherwise a plain subscriber
header. Free trial eligibility is new in
ModelState, read fromSubscriptions. Copy sits indonottranslate.xmluntil sign-off, and the old Plus/Pro header strings stay for the flag-offpath until the flag is retired.
Steps to test this PR
Feature 1
updatedPickersoff, open the model picker and confirm it looks exactly as it doeson develop: no sublines, Plus and Pro section headers
updatedPickersin the feature flag menu, force stop and relaunchdivider, then the gated models with a trailing ellipsis
gated for you
for Plus
UI changes