Move EntityLookup into tracker-detection-api - #9800
Merged
aibrahim- merged 1 commit intoSep 23, 2026
Merged
Conversation
Contributor
|
aibrahim-
added this pull request to stack #9805
September 17, 2026 10:20
aibrahim-
force-pushed
the
feature/aibrahim/tracker-detection/phase2-entity-lookup
branch
from
September 17, 2026 10:28
f019653 to
760d1bc
Compare
aibrahim-
marked this pull request as ready for review
September 21, 2026 13:11
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Base automatically changed from
feature/aibrahim/tracker-detection/phase1-api-models
to
develop
September 22, 2026 10:09
EntityLookup moves from browser-api into tracker-detection-api, keeping its com.duckduckgo.app.trackerdetection package so SiteFactoryImpl and the other consumers need no import changes. They already reach it through the browser-api re-export added in the previous change. tracker-detection-api gains androidx.annotation for @workerthread, which it previously picked up transitively through browser-api. Asana: https://app.asana.com/1/137249556945/task/1216988877446431 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
aibrahim-
force-pushed
the
feature/aibrahim/tracker-detection/phase2-entity-lookup
branch
from
September 22, 2026 10:09
760d1bc to
5d13cd9
Compare
landomen
approved these changes
Sep 23, 2026
aibrahim-
deleted the
feature/aibrahim/tracker-detection/phase2-entity-lookup
branch
September 23, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1216988877446431
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/task/1216706645739239
API Proposals URL(s) (if applicable): to follow — will be added before merge
Description
Phase 2 of the tracker-detection extraction, stacked on the Phase 1 PR. Pure move, no behaviour change.
EntityLookupmoves frombrowser-apiintotracker-detection-api, keeping itscom.duckduckgo.app.trackerdetectionpackage, soSiteFactoryImpland the other consumers need no import changes. They already reach it through thebrowser-apire-export added in the previous PR.tracker-detection-apigainsandroidx.annotationfor@WorkerThread, which it previously picked up transitively throughbrowser-api.The goal of this phase is that everything
:appproduction code consumes goes through the api, with no:app→ impl class imports.Steps to test this PR
Tracker entity attribution still works
UI changes