Skip to content

Move EntityLookup into tracker-detection-api - #9800

Merged
aibrahim- merged 1 commit into
developfrom
feature/aibrahim/tracker-detection/phase2-entity-lookup
Sep 23, 2026
Merged

aibrahim- merged 1 commit into
developfrom
feature/aibrahim/tracker-detection/phase2-entity-lookup

Conversation

@aibrahim-

@aibrahim- aibrahim- commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/task/1216988877446431
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/task/1216706645739239
API Proposals URL(s) (if applicable): to follow — will be added before merge

Description

Phase 2 of the tracker-detection extraction, stacked on the Phase 1 PR. Pure move, no behaviour change.

  • EntityLookup moves from browser-api into tracker-detection-api, keeping its com.duckduckgo.app.trackerdetection package, so SiteFactoryImpl and the other consumers need no import changes. They already reach it through the browser-api re-export added in the previous PR.
  • tracker-detection-api gains androidx.annotation for @WorkerThread, which it previously picked up transitively through browser-api.

The goal of this phase is that everything :app production code consumes goes through the api, with no :app → impl class imports.

Steps to test this PR

Tracker entity attribution still works

  • Build and run the app
  • Visit a site with trackers and open the privacy dashboard
  • Confirm trackers are still grouped under the right company names

UI changes

Before After
No UI changes No UI changes

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ API Proposal reminder

This PR changes the public surface of one or more -api modules, but the API Proposals field of the PR description is empty. This is a non-blocking reminder — please double-check whether a proposal is needed.

Changed -api source files:

  • browser-api/src/main/java/com/duckduckgo/app/trackerdetection/EntityLookup.kt
  • tracker-detection/tracker-detection-api/src/main/java/com/duckduckgo/app/trackerdetection/EntityLookup.kt

To clear this reminder, edit the PR description and either:

  • add the approved API Proposal link(s) in the API Proposals field (one per line), or
  • write None there if this PR does not change the public API (e.g. KDoc, comments, tests).

See the API Proposals section in .claude/docs/contributions.md for details.

@aibrahim-
aibrahim- added this pull request to stack #9805 September 17, 2026 10:20
@aibrahim-
aibrahim- force-pushed the feature/aibrahim/tracker-detection/phase2-entity-lookup branch from f019653 to 760d1bc Compare September 17, 2026 10:28
@aibrahim-
aibrahim- marked this pull request as ready for review September 21, 2026 13:11

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

Base automatically changed from feature/aibrahim/tracker-detection/phase1-api-models to develop September 22, 2026 10:09
EntityLookup moves from browser-api into tracker-detection-api, keeping
its com.duckduckgo.app.trackerdetection package so SiteFactoryImpl and
the other consumers need no import changes. They already reach it
through the browser-api re-export added in the previous change.

tracker-detection-api gains androidx.annotation for @workerthread,
which it previously picked up transitively through browser-api.

Asana: https://app.asana.com/1/137249556945/task/1216988877446431

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@aibrahim-
aibrahim- force-pushed the feature/aibrahim/tracker-detection/phase2-entity-lookup branch from 760d1bc to 5d13cd9 Compare September 22, 2026 10:09
@aibrahim-
aibrahim- requested a review from landomen September 22, 2026 16:14
@landomen landomen self-assigned this Sep 23, 2026
@aibrahim-
aibrahim- added this pull request to the merge queue Sep 23, 2026
Merged via the queue into develop with commit 0628ac0 Sep 23, 2026
23 of 25 checks passed
@aibrahim-
aibrahim- deleted the feature/aibrahim/tracker-detection/phase2-entity-lookup branch September 23, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants