Skip to content

Move tracker-detection models into tracker-detection-api #9799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aibrahim- merged 1 commit into from
Sep 22, 2026
Merged

Move tracker-detection models into tracker-detection-api #9799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions browser-api/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ plugins {
apply from: "$rootProject.projectDir/gradle/android-library.gradle"

dependencies {
api project(path: ':tracker-detection-api')
implementation project(path: ':navigation-api')
api project(path: ':browser-mode-api')
implementation project(path: ':design-system')
Expand Down
1 change: 1 addition & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ subprojects {
&& dependencyPath != ":js-messaging-api"
&& dependencyPath != ":browser-api"
&& dependencyPath != ":browser-mode-api"
&& dependencyPath != ":tracker-detection-api"

@landomen landomen Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is acceptable to do considering this are core entities / classes.

) {
if (projectPath.endsWith(":feature-toggles-api") &&
(dependencyPath == ":experiments-api"
Expand Down
4 changes: 0 additions & 4 deletions tracker-detection/tracker-detection-api/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ plugins {

apply from: "$rootProject.projectDir/gradle/android-library.gradle"

dependencies {
implementation project(path: ':browser-api')
}

android {
namespace 'com.duckduckgo.tracker.detection.api'
}
0 ...ckgo/app/trackerdetection/model/Entity.kt → ...ckgo/app/trackerdetection/model/Entity.kt
View file
Open in desktop
File renamed without changes.
0 ...p/trackerdetection/model/TrackingEvent.kt → ...p/trackerdetection/model/TrackingEvent.kt
View file
Open in desktop
File renamed without changes.
Loading