Skip to content

Onboarding: Disable Fire Button highlight if Trackers Blocked dialog is showing - #9788

Merged
nalcalag merged 5 commits into
developfrom
feature/noelia/supress_fire_highlight_with_trackers_blocked_dialog
Sep 29, 2026
Merged

nalcalag merged 5 commits into
developfrom
feature/noelia/supress_fire_highlight_with_trackers_blocked_dialog

Conversation

@nalcalag

@nalcalag nalcalag commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1176956903599313/task/1217885575503833?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

Disable the Fire Button highlight if it’s already showing at the time the Trackers Blocked highlight is triggered

Steps to test this PR

Feature 1

  • Go through linear onboarding and get to the in-browser stage.
  • Perform a search.
  • You will be prompted to "visit a site".
  • Pick a site that doesn't immediately get trackers blocked, like the suggested ebay.com.
  • A "Go ahead - keep browsing" CTA is shown.
  • Do not click "Got it" but rather continue browsing as the CTA suggests.
  • Go directly to a website that has trackers blocked, for example yahoo.com.
  • A "trackers blocked" CTA is shown
  • Verify fire button highlight animation is not playing
  • Verify privacy shield button highlight animation is playing
  • Tap on 'Got it!'
  • Verify fire button highlight animation is playing
  • Verify privacy shield button highlight animation is not playing

UI changes

Before After
Screenshot_20260818_103152_DuckDuckGo Screenshot 2026-09-11 at 14 47 22

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag
nalcalag marked this pull request as ready for review September 11, 2026 21:45

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@LukasPaczos LukasPaczos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nalcalag I still see the fire button animation while the second page is loading:

Screen_recording_20260914_173526.mp4

Perhaps we can hoist the fix somewhere up the flows chain, to CtaViewModel perhaps?

Comment thread app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt Outdated

@mikescamell mikescamell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor comment about naming but feel free to merge once addressed.

I tested and it worked as expected, but I as mentioned on MM I saw what Lukasz P. Saw here: #9788 (review)

As you mentioned, this is a quick fix to stop both animating at the same time and we need to address the rest as a follow up.

@nalcalag
nalcalag force-pushed the feature/noelia/supress_fire_highlight_with_trackers_blocked_dialog branch from 31a0abc to 5e953a9 Compare September 29, 2026 12:25
@nalcalag
nalcalag added this pull request to the merge queue Sep 29, 2026
Merged via the queue into develop with commit 658818d Sep 29, 2026
16 checks passed
@nalcalag
nalcalag deleted the feature/noelia/supress_fire_highlight_with_trackers_blocked_dialog branch September 29, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants