Onboarding: Disable Fire Button highlight if Trackers Blocked dialog is showing - #9788
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
LukasPaczos
left a comment
There was a problem hiding this comment.
@nalcalag I still see the fire button animation while the second page is loading:
Screen_recording_20260914_173526.mp4
Perhaps we can hoist the fix somewhere up the flows chain, to CtaViewModel perhaps?
mikescamell
left a comment
There was a problem hiding this comment.
LGTM, only one minor comment about naming but feel free to merge once addressed.
I tested and it worked as expected, but I as mentioned on MM I saw what Lukasz P. Saw here: #9788 (review)
As you mentioned, this is a quick fix to stop both animating at the same time and we need to address the rest as a follow up.
…how fire dialog if MAX_TABS_OPEN_FIRE_EDUCATION reached, same as highlight
31a0abc to
5e953a9
Compare

Task/Issue URL: https://app.asana.com/1/137249556945/project/1176956903599313/task/1217885575503833?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Disable the Fire Button highlight if it’s already showing at the time the Trackers Blocked highlight is triggered
Steps to test this PR
Feature 1
UI changes