Feature 3395 remove r at unittest#3400
Open
hsoh-u wants to merge 11 commits into
Open
Conversation
added 6 commits
June 9, 2026 16:58
21 tasks
Collaborator
|
As discussed at the METplus project meeting on June 16, 2026, recommend removing all references to the |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Expected Differences
Two unit tests (
unit_trmm2nc.xmlandunit_plot_tc.xml) were removed atinternal/test_unit/bin/unit_test.shand GHA. This causes 7 less outputs:Removed PERL and R scripts at:
Two R scripts were converted to python
Removed the shell scripts with reference of MET_TEST_RSCRIPT, but associated R scripts were not converted to Python.
Two shell scripts were modified. MET_TEST_RSCRIPT was replaced with MET_PYTHON_BIN_EXE.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
ran unit test manually and by using GHA
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
NA
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
7 less output files at
trmm2ncandplot_tcsub directoriesIf yes, create a new Update Truth METplus issue to describe them.
Not sure
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release