Conversation
…choice; refined/added some type annotations and comments
…to support proper typing for #151
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 97.02% 96.85% -0.18%
==========================================
Files 54 54
Lines 7052 7082 +30
Branches 1138 1143 +5
==========================================
+ Hits 6842 6859 +17
- Misses 148 152 +4
- Partials 62 71 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breaking change was made to the generic
Serializedclass to remove support for a singleconvertercallable that handled either serialization xor deserialization. Instead, it now requires aserializerthat provides an interface withload/dumpand/orloads/dumps, similar to the json and pickle modules.Additionally, the
pass_fileparameter was removed fromJson,Pickle, andSerialized. When the providedserializerhas aloadordumpattribute, it will always be preferred over theloads/dumpsvariants.