Skip to content

More Typing Improvements + Minor Breaking Change to inputs.files.Serialized#158

Merged
dskrypa merged 3 commits into
mainfrom
dev
Mar 29, 2026
Merged

More Typing Improvements + Minor Breaking Change to inputs.files.Serialized#158
dskrypa merged 3 commits into
mainfrom
dev

Conversation

@dskrypa

@dskrypa dskrypa commented Mar 29, 2026

Copy link
Copy Markdown
Owner

A breaking change was made to the generic Serialized class to remove support for a single converter callable that handled either serialization xor deserialization. Instead, it now requires a serializer that provides an interface with load / dump and/or loads / dumps, similar to the json and pickle modules.

Additionally, the pass_file parameter was removed from Json, Pickle, and Serialized. When the provided serializer has a load or dump attribute, it will always be preferred over the loads / dumps variants.

@codecov

codecov Bot commented Mar 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.05525% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.85%. Comparing base (33dda01) to head (9d11cf4).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/cli_command_parser/inputs/_typing.py 62.06% 0 Missing and 11 partials ⚠️
lib/cli_command_parser/inputs/utils.py 88.33% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   97.02%   96.85%   -0.18%     
==========================================
  Files          54       54              
  Lines        7052     7082      +30     
  Branches     1138     1143       +5     
==========================================
+ Hits         6842     6859      +17     
- Misses        148      152       +4     
- Partials       62       71       +9     
Flag Coverage Δ
unittests 96.83% <90.05%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dskrypa dskrypa merged commit c7be002 into main Mar 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant