Skip to content

Fixed mypy type detection for Parameter values#156

Merged
dskrypa merged 4 commits into
mainfrom
dev
Mar 21, 2026
Merged

Fixed mypy type detection for Parameter values#156
dskrypa merged 4 commits into
mainfrom
dev

Conversation

@dskrypa

@dskrypa dskrypa commented Mar 21, 2026

Copy link
Copy Markdown
Owner

Related to #151, this PR fixes type detection by mypy for Parameter values, without the need to explicitly annotate the wrapped type in most scenarios.

@codecov

codecov Bot commented Mar 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.62963% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.02%. Comparing base (2988d74) to head (d885bb5).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/cli_command_parser/conversion/argparse_ast.py 78.94% 5 Missing and 3 partials ⚠️
lib/cli_command_parser/parameters/_typing.py 0.00% 6 Missing ⚠️
lib/cli_command_parser/parameters/base.py 88.88% 1 Missing and 4 partials ⚠️
lib/cli_command_parser/conversion/cli.py 0.00% 4 Missing ⚠️
lib/cli_command_parser/conversion/visitor.py 84.21% 1 Missing and 2 partials ⚠️
lib/cli_command_parser/context.py 66.66% 0 Missing and 1 partial ⚠️
lib/cli_command_parser/typing.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   97.24%   97.02%   -0.23%     
==========================================
  Files          52       54       +2     
  Lines        7036     7052      +16     
  Branches     1126     1138      +12     
==========================================
  Hits         6842     6842              
- Misses        136      148      +12     
- Partials       58       62       +4     
Flag Coverage Δ
unittests 97.00% <89.25%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dskrypa dskrypa merged commit ddfd20e into main Mar 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant