Conversation
…el to improve documentation; updated pre-commit config
…nager to Iterator
…ability test for file/path inputs
…c tests without reload and be able to test pickleability of ErrorHandler; fixed pickleability of ErrorHandler; fixed additional test module permissions to be executable
… other platform keyboard interrupt handler test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 98.01% 97.94% -0.07%
==========================================
Files 49 52 +3
Lines 6786 6818 +32
Branches 1068 1074 +6
==========================================
+ Hits 6651 6678 +27
- Misses 110 111 +1
- Partials 25 29 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed pickleability of
ActionFlagandErrorHandlerinstances soCommandmethods can be called in aProcessPoolExecutor, for example.The
error_handlingmodule needed to be split into a package to be able to isolate Windows-specific handlers so that pickling of sharedErrorHandlerinstances could be tested. The old tests reloaded the module to cause Windows-specific logic to run, which Pickle didn't like.Fixed permissions for all tests via
chmod +x tests/test_*/test_*.pyor similar so they can be executed directly on Linux.