fix(install): land queue-worker throws on the task instead of the process - #58
Merged
Merged
Conversation
…cess pumpQueue voids runPluginMutation(...).finally(...) with no catch, so any throw inside the mutation — reachable via the allowBuilds recovery path's writeFileSync (EACCES/EROFS/ENOSPC) — surfaces as an unhandled rejection (process-fatal on Node >= 15) while the queue itself keeps pumping in the finally. Catch it, mark the task failed with an [internal] line, and let the existing finally branch log it like any other install failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pumpQueuerunsvoid runPluginMutation({ ...options, task }).finally(() => { ... })with no.catch. A rejection inside the mutation is therefore an unhandled rejection — process-fatal on Node ≥ 15 — while the.finallystill runs and pumps the next task: the worst of both (crash + queue continuing).A reachable throw exists: the
allowBuildsrecovery path callswriteFileSync(profile.ts, the only I/O in that path not wrapped in try/catch — the precedingreadFileSyncis). It runs precisely in flaky environments (that's what the recovery exists for), so EACCES/EROFS/ENOSPC there is plausible.Changes
Catch before the finally: land the throw on the task (
failedstatus,[internal]line viapushLine), then let the existing.finallybranch log install-failure as usual. Cancelled tasks are left alone.Testing
Full suite
node --test: 51/51 pass;npm run typecheckclean.Proof