Sync SwipeTracker to GNOME 50#295
Conversation
|
Hi! Yes, this would be good to update, thank you! |
d26822b to
e7a81d8
Compare
Includes [gnome-shell!3931][1], [gnome-shell!3967][2], [gnome-shell!3997][3] and [gnome-shell!4062][4]. [1]: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3931 "Use const declarations where possible" [2]: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3967 "swipeTracker: Immediately flip delta in RTL locales" [3]: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3997 "swipeTracker: Handle touchpad gestures on actor" [4]: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4062 "swipeTracker: Handle invalid position when finding previous point"
e7a81d8 to
ece8a99
Compare
|
I tested this PR on two separate laptops, a ThinkPad and a Samsung Galaxy Book, and they both follow the trackpad correctly. The test matrix was:
Additionally tested some non-exhaustive configurations with a mix of different options (Title Position, Perspective Correction, Easing Function, etc.). Also tested a matrix of 1 and 2 with a mouse scroll on a desktop. Finally tested the touchpad with the laptop in Portrait mode, with a matrix of 2 and 3. I didn't test LTR layouts. Edit: sample video from the default configuration Screencast.From.2026-04-13.01-39-54.mp4I'm not 100% sure which scrolling direction is the correct one, but they were updated according to the options. Might need a global -1 multiplier if the initial direction is wrong. Are there any other tests that could be useful here? |
|
Thank you! Do you in any way automate this process of diffs? |
|
Not really. I did |
Not sure if you're interested in doing this right now, but these would be changes in
swipeTracker.jsintroduced between GNOME 49.rc and GNOME 50.rc. They should work with GNOME 49 too, however the orientation changes could be a bit risky for both versions. For comparison, check commits forswipeTracker.json:I'm opening as draft right now, but, if there is interest, I could do a proper test and open it to review if it works.